Conversation
Contributor
Author
|
This change reduced our CPU usage a nice bit |
Papamaci444
reviewed
Sep 21, 2026
| ]; 0b}; | ||
|
|
||
| /- exit early if 0 row count, return 0b for no changes to table | ||
| if[0 = arows;:0b]; |
Contributor
There was a problem hiding this comment.
What happens if a table didn't receive an update for the day? We still want that one to end up on the disk. We might could introduce another flag "eod" - this would be only called once a day and it definitely would write down all tables.
Rest could be same as your change.
Contributor
Author
There was a problem hiding this comment.
Yes this requires more thought. I notice that (in my setup) the sort process calls .wdb.initmissingtables on the wdb only after sort + p attr etc is complete. This could take some time and therefore is too late; it needs to be called around EOD
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
savetables function doing a lot of unnecessary work when table rows = 0. Added a check to exit early.